Login  |  Register

Author Topic: Possible bug: Guardian vs Swamp Hag  (Read 557 times)

Offline jmjm

  • Newbie
  • *
  • Posts: 14
    • View Profile
Possible bug: Guardian vs Swamp Hag
« on: 05 March 2018, 09:57:45 PM »
I suspect DO might be incorrectly interpreting this card interaction:

The Guardian is not still in play when the Guardian player is buying stuff. The sequence is:

  • Player 1, night phase: plays Guardian.
  • Player 2, action phase: plays Swamp Hag.
  • Player 1, action phase: Guardian goes to the discard pile.
  • Player 1, buy phase: buys a card and maybe takes a curse?

DO seems to think that Player 1 should gain a curse.  But a reading of the cards (Guardian blocks the action of Swamp Hag when SH is played, not when the buy happens) might indicate that Player 1 should not receive that curse.

What do you think?

As seen on reddit!  https://www.reddit.com/r/dominion/comments/826hvf/guardian_vs_swamp_hag/

Offline Cave-O-Sapien

  • Full Member
  • ***
  • Posts: 227
    • View Profile
Re: Possible bug: Guardian vs Swamp Hag
« Reply #1 on: 05 March 2018, 10:58:22 PM »
Why does the Guardian go to the discard pile during the action phase?

But, even if it did, it would still protect you. The key is that it is out when the Swamp Hag is PLAYED, not when you would suffer the effects of the Swamp Hag.

Offline Stef

  • Administrator
  • *****
  • Posts: 751
    • View Profile
Re: Possible bug: Guardian vs Swamp Hag
« Reply #2 on: 05 March 2018, 11:02:16 PM »
This is handled correctly online. (AFAIK)
You say that DO seems to think you get a curse, but do you have a sample game to back that up?
Because I think you don't get the curse online.

What really helps in these cases is if you...
a) notice the situation in a game or
b) recreate the situation against a bot
... and then write down the game number and maybe the turn or decision where you think something goes wrong. That way someone else can load that game and see exactly what DO does and what you mean.

Offline Ingix

  • Global Moderator
  • ***
  • Posts: 1148
    • View Profile
Re: Possible bug: Guardian vs Swamp Hag
« Reply #3 on: 06 March 2018, 12:31:48 AM »
I assume jmjm is talking about game #12281566, where both cards were present. However, unless some undos were involved (which cannot be seen in the game log), the situation jmjm describes never occurs.

Unless I missed something, the situation where one player played a Swamp Hag while the other had a Gurdian out happened twice: on turn 14/14 of opp./jmjm, and again on turn 18/18 of opp./jmjm (so in both cases the opponent played the Guardian and jmjm the Swamp Hag).

In turn 15 of the opponent, he did not buy anything, so it it cannot be decided if Guardian would have stopped Swamp Hag (in a replay with the bot as opponent, the bot bought a card, but did not gain a Curse, so Gurdian worked correctly in that replay).

Since jmjm ended the game on turn 18, there was no turn 19 for the opponent to be affected by Swamp Hag.

What I can think of what possibly happened is that (because there were many Guardians bought in the the game) jmjm misremembered and took the turn he gained the +$1 from his Guardian as the turn he played her. Gurdian is usually only a short time visible on the turn she is played, and usually not visible on opponent's turn, but then a full turn when she gives the +$1. So I think it is possible to misattribute seeing her in play to the (usually) more important 'protect me from attack' than the +$1 effect.

Offline josh bornstein

  • Sr. Member
  • ****
  • Posts: 272
    • View Profile
Re: Possible bug: Guardian vs Swamp Hag
« Reply #4 on: 06 March 2018, 12:51:32 AM »
(I am *sure* this has been mentioned before.  But...)

It would be great if DO had a clean and ongoing visual signal that there is some enduring effect.  I was thinking of a bright red, um, somthing--against a black background--in one corner of the screen.  If a player hovers her cursor over that icon, then it would give details about what card still has effect and/or what the effect is.  The cursor would just sit there (hey, blinking would be even better  :) ) till the effect ran out.  Or, it would be something that the players could "x" out, once they had seen it, if they wanted to clear their screen as much as possible.

In real life games, of course, if you plop down a Guardian with a smug smile on your face, I know not to waste a move by playing an attack next turn (putting aside other reasons to play an attack card, like the 2 coins for Militia, for example).  But online, it is way too easy to miss a duration card.  And carefully checking the log after each turn would *really* slow down the game...especially when players are on a phone or tablet, where it takes a lot longer to look at the log.

Would this be easy to program?  Or, is it actually a complicated fix to do?

Offline Ingix

  • Global Moderator
  • ***
  • Posts: 1148
    • View Profile
Re: Possible bug: Guardian vs Swamp Hag
« Reply #5 on: 06 March 2018, 09:54:19 AM »
I totally agree.

The first step was done with implementing such signaling for the duration attacks (Swamp Hag, Haunted Woods, Enchantress) and the states of Nocturne. The next step would be an extension to other duration effects that work across players, which I *think* would be the 'duration attack blockers' Lighthouse, Guardian and Champion.

As for implementation, there is always the problem of finding screen real estate to communicate such a condition, and then the client must be made aware of the condition (usually it is enough if the server knows you are protected).

Personally I would suggest a shield icon in each player's info box (that contains their name, VP, etc.), if that player is currently protected by a Lighthouse, Guardian or Champion effect (maybe flashing on your turn, so you are made aware of it).